softsimon

Results 74 comments of softsimon

I like it this way: ``` (function() { 'use strict'; angular .module('app.widget.activeplaces') .component('activePlaces', { bindings: { data: '

This is also opinionated but I like to keep it simple. No vm, just $ctrl. No division of what to be exposed to the view. Thoughts? ``` (function(){ 'use strict';...

Sure. I will be waiting for your Pull request 👍

I went through and upgraded the whole library to support 9+ without changing any API that I remember. The library is renamed and replaced to get rid of the "angular-2"...

I haven't tried 9.x but I believe it should work. That error message seems very general and is not pointing specifically to the library. Could you try the suggested solutions...

Ok, it seems the error is caused by compiling to es2015 which IE11 does not have. And compiling to es5 cause the build error: `Error on worker #1: Error: getInternalNameOfClass()...

@kylebradshaw were you able to find a solution?

> Thanks for the PR but maybe the correct fix is to disable the mempool loop in the Lightning backend? As long as the mempool loop is working it should...

> Yes, that's what I'm saying, instead of disabling the "Fetching transactions" debug log, isn't what we really want to correctly fix the issue of the mempool looper running in...

Logger tags is a good idea. But it would be better to add it as a separate input parameter to the logger method and having it added later, with a...