turnstyle icon indicating copy to clipboard operation
turnstyle copied to clipboard

Not sure why jobs are running concurrently

Open ronlut opened this issue 4 years ago • 4 comments

Thanks for the great action. I have a pretty simple scenario where I want to limit a job to never run concurrently (deploy to github pages). Can't get it to work for some reason, probably missing something.

My workflow is here and the runs are #1 #2 (had to cancel the 2nd as it already started without waiting for the first one). Relevant job to block is gh-pages ("Deploying to Github Pages")

Thanks

ronlut avatar Sep 09 '20 14:09 ronlut

Hi I also have the same issue. It is happening on a private repo so I can't share any workflow logs but would be happy to provide debug info if there is something specific that I can look for.

Thanks for making this though! GH workflows really should have this built-in.

tymokvo avatar Oct 27 '20 21:10 tymokvo

@ronlut Your workflow doesn't have the action configured (softprops/turnstyle@v1). See the README on that.

schof avatar Nov 19 '20 22:11 schof

@schof take a look at his git history, he had it there but I guess it wasn't working for him so he removed it.

onedr0p avatar Nov 26 '20 13:11 onedr0p

@ronlut @tymokvo , the problem could be related to what we are facing too, I have raised a PR for this #31 In my testing I found out the action wasn't pulling queued runs and this was allowing runs to progress without waiting.

vigneshmsft avatar Dec 15 '20 09:12 vigneshmsft

Close as fixed. Thanks!

chenrui333 avatar Jun 19 '24 23:06 chenrui333

Try out 2.1.0 release.

chenrui333 avatar Jun 19 '24 23:06 chenrui333

What a great comeback!

onedr0p avatar Jun 20 '24 00:06 onedr0p