action-gh-release icon indicating copy to clipboard operation
action-gh-release copied to clipboard

Feature request: Wait for all Asset uploads to complete before publishing release

Open budak7273 opened this issue 1 year ago • 3 comments

Hello, we have been successfully using this action to auto-publish releases that contain ~12.5 GB of binaries (game engine) split into multiple files. However, it seems like the action 'publishes' the release (in the sense that it is available for users to download files from and webhooks announcing release are fired) before all Assets are uploaded. This leads to a confusing first few minutes after release where it looks like the build has somehow failed because most of the files are missing from the release. In actuality, they are still being uploaded and the action is still running.

Could the current behavior lead to an error case where the release is published, but uploading fails, resulting in an incomplete yet published release?

Can the action be extended to allow waiting to publish until all assets have finished uploading? I don't see anything in the readme that suggests it would be possible with the currently available options.

budak7273 avatar Sep 18 '24 16:09 budak7273

Example right after webhook sent out:

Image

The action is still running:

Image

A few minutes later:

Image

Even later:

Image

budak7273 avatar Sep 21 '24 22:09 budak7273

I ran into this too.

I presume the only solution currently is to use this action to create a draft release, then in the next step after this action runs, to change the status of the release to public using the GitHub CLI?

edmorley avatar Mar 31 '25 18:03 edmorley

This is causing issues for downstream workflows that rely on the published event and attempt to download assets via gh release download.

I have not yet tried it (nor have I looked at this action's code to see if this is already done), but I wonder if using gh release create directly would ensure the assets are uploaded before the command completes.

btrautmann avatar Jun 13 '25 14:06 btrautmann