action-gh-release icon indicating copy to clipboard operation
action-gh-release copied to clipboard

Published 20 hours ago • verified publisher icon softprops

Do not raise misleading warning

Open Drowze opened this issue 11 months ago • 2 comments

When the input input_files is not defined, the config.input_files will default to an empty array, which always evaluate to true - that was triggering a misleading warning suggesting that the user did input something but the input didn't point to any file.

As a fix, simply check if the array is empty as well :)

Drowze avatar Sep 21 '23 15:09 Drowze

@softprops can we merge this? would fix the following warning ("not include valid file") always being thrown whenever input_files is not defined. Screenshot 2023-11-01 at 14 29 11

Drowze avatar Nov 01 '23 17:11 Drowze

~~Duplicate of~~ Related to #384 ? :)

rpdelaney avatar Nov 28 '23 15:11 rpdelaney

@Drowze this makes a lot of sense to me!

softprops avatar Mar 08 '24 20:03 softprops

this should be available in the new v2 tag

softprops avatar Mar 08 '24 21:03 softprops