action-gh-release
action-gh-release copied to clipboard
Add support for make_latest property
Closes #297
This PR supports the make_latest property of the releases REST API.
I've tested this on my fork and it works well for me. I've kept the behaviour with previous versions by defaulting to true for this property.
I also:
- updated a dependency via
npm audit fixto fix a high risk npm security flag - updated tests
- updated documentation
Please note: make_latest is oddly a string which is why parseConfig returns a string for this property. See the docs.
Thanks!
There's some nuance in the docs that give me pause for the default though
Drafts and prereleases cannot be set as latest.
Does this mean those creating drafts and prereleases would start getting errors with this actions new default?
Defaults to true for newly published releases. legacy specifies that the latest release should be determined based on the release creation date and higher semantic version.
I'm wondering if legacy is the better default for backwards compat or event better leaving it undefined as a default unless a user specifies it explicitly to guarantees compatibility with current behavior
Leaving undefined sounds probably better I agree. I'll add a change for that.
@softprops I've adjusted the behaviour to default to undefined.
Hi, will this PR be merged?
Would also like to see this feature.
I'm also interested in this feature
@softprops any updates on this? :)
@softprops Please, can your merge this PR? That would be great! Thank you!
any news on this?
Could support to update an existing tag with make_latest be added? Or would this would to set an existing tag to the latest? https://github.com/softprops/action-gh-release/issues/385
Any news on this ? That would be great !
@samueljseay thanks for the pull and sorry for the delay
this should be available in the new v2 tag