action-gh-release icon indicating copy to clipboard operation
action-gh-release copied to clipboard

Published 20 hours ago • verified publisher icon softprops

add 'update_tag' option

Open iTrooz opened this issue 2 years ago • 2 comments

This PR does two things :

  • adds the 'update_tag' option
  • refactor the big try/catch block, to allow better error handling (a random error will not create a new release)

Fixes #171

iTrooz avatar Dec 18 '22 20:12 iTrooz

I need this feature for continuous releases . @softprops How can I help test this ?

sithlord48 avatar Feb 22 '23 12:02 sithlord48

@softprops Can you please take a look here finally? This is a very useful feature and our project would highly benefit from it. Thank you very much!

mkurz avatar Mar 04 '24 14:03 mkurz

@iTrooz can you fix the merge conflicts? Thanks!

chenrui333 avatar Jul 17 '24 18:07 chenrui333

@iTrooz ping

chenrui333 avatar Jul 19 '24 12:07 chenrui333

Hey, unless the maintainer shows interest in merging this, I'm not interested in updating it, sorry

iTrooz avatar Jul 19 '24 13:07 iTrooz

Oops, I just realized that you are a maintainer of this repository. I will update this PR soon

iTrooz avatar Jul 19 '24 13:07 iTrooz

yeah, please :)

chenrui333 avatar Jul 21 '24 12:07 chenrui333

Why did I think making a refactor on a feature PR was a good idea..

Anyway, done !

Note that I have no idea how github orders release, using update_tag may not bring the release to the top. But it will avoid a spam of notifications to users subscribed :)

iTrooz avatar Jul 22 '24 22:07 iTrooz

@chenrui333 Ready for review/merge

I already tested this PR, but if anyone wants to double-check, please do so

iTrooz avatar Jul 22 '24 22:07 iTrooz

Closing in favor of https://github.com/softprops/action-gh-release/issues/171#issuecomment-1229559873 (See also https://github.com/softprops/action-gh-release/pull/293#discussion_r1687263755)

iTrooz avatar Jul 30 '24 14:07 iTrooz