sl-ember-components icon indicating copy to clipboard operation
sl-ember-components copied to clipboard

Why are we setting the disabled state of the children sl-radio components?

Open notmessenger opened this issue 9 years ago • 1 comments

According to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/fieldset, the disabled property causes

the form controls that are its descendants, except descendants of its first optional element, are disabled, i.e., not editable. They won't receive any browsing events, like mouse clicks or focus-related ones. Often browsers display such controls as gray.

Given this, why are we setting the disabled state of the children sl-radio components in initialize()?

notmessenger avatar Aug 25 '15 15:08 notmessenger

I don't think the radio-group component should be tagName='fieldset'. We should be following: http://getbootstrap.com/css/#checkboxes-and-radios. The radio-group tagName should probably be "div" and the disabled setting of children should remain.

SpikedKira avatar Nov 12 '15 22:11 SpikedKira