sl-ember-components
sl-ember-components copied to clipboard
Troubleshoot/refactor listener issues
This change was introduced in order to resolve failing tests @joshforisha was encountering at /tests
:
https://github.com/softlayer/sl-ember-components/blob/71ae7ee739b7f9b2d20780c6b166da781ef3857b/addon/components/sl-date-range-picker.js#L104
This is not a change that should have had to have been implemented though so any of the following things may be the cause:
- either jQuery isn't cleaning something up correctly
- this component isn't cleaning something up correctly
- the sl-date-picker component it is relying on isn't cleaning something up correctly
This issue's work will dovetails with https://github.com/softlayer/sl-ember-components/issues/426
Just removed that line since it was not needed. Tests still pass.
https://github.com/softlayer/sl-ember-components/pull/435 intersects this same file/line
#1458 will likely close this issue as there is no longer a reliance on jquery event binding.