sl-ember-components icon indicating copy to clipboard operation
sl-ember-components copied to clipboard

Define capabilities and API for sl-pagination

Open notmessenger opened this issue 9 years ago • 6 comments

This issue is where discussion about all of the things we want to change about the sl-pagination component should occur and the final definition of its capabilities and API are defined. As these items are discussed and vetted, issues will be created to work any individual tasks, with this issue serving as the overall source of progress.

To indicate that a capability of the component needs to be verified, add a comment with **VERIFY** as the first line. To propose a change to the component, add a comment with **PROPOSAL** as the first line. To indicate that something needs to be researched, add a comment with **RESEARCH** as the first line.

As you are leaving comments regarding any of these VERIFY, PROPOSAL, or RESEARCH comments, link back to the comments link in your own so that the conversation can be more easily followed (in absence of threaded conversation support in Github). This should be done on the first line of the comment via **RE: <url>**

Capabilities and API

  • [ ] ARIA support
  • [ ] ...

Tasks Adding them here until issues are created

  • Update documentation for each change
  • Complete review of documentation against capabilities

Issues tracking these efforts

https://github.com/softlayer/sl-ember-components/issues?q=is%3Aopen+is%3Aissue+milestone%3A%22v0.13.0+%28Final+push+for+a+1.0.0+release%29%22+label%3Asl-pagination

notmessenger avatar Dec 08 '15 18:12 notmessenger

PROPOSAL

support "pagination-lg" and "pagination-sm" classes for sizing

SpikedKira avatar Dec 18 '15 15:12 SpikedKira

PROPOSAL

~~show pages like:~~ ~~http://getbootstrap.com/components/#pagination~~

~~instead of one unclickable area that lists current page of total~~ completed by #1339

SpikedKira avatar Dec 18 '15 15:12 SpikedKira

PROPOSAL

add a property for maximum pages to show and show floor(maximum/2) before current and floor(maximum/2) after current

SpikedKira avatar Dec 18 '15 15:12 SpikedKira

PROPOSAL

add a default declaration for changePage action

SpikedKira avatar Dec 18 '15 15:12 SpikedKira

PROPOSAL

require totalPages in init

SpikedKira avatar Jan 13 '16 16:01 SpikedKira

@SpikedKira Is https://github.com/softlayer/sl-ember-components/issues/1266#issuecomment-165810270 addressed by https://github.com/softlayer/sl-ember-components/issues/564 ?

notmessenger avatar Jan 13 '16 21:01 notmessenger