sl-ember-components
sl-ember-components copied to clipboard
softlayer
Define capabilities and API for sl-chart
This issue is where discussion about all of the things we want to change about the sl-chart component should occur and the final definition of its capabilities and API are defined. As these items are discussed and vetted, issues will be created to work any individual tasks, with this issue serving as the overall source of progress.
To indicate that a capability of the component needs to be verified, add a comment with **VERIFY** as the first line.
To propose a change to the component, add a comment with **PROPOSAL** as the first line.
To indicate that something needs to be researched, add a comment with **RESEARCH** as the first line.
As you are leaving comments regarding any of these VERIFY, PROPOSAL, or RESEARCH comments, link back to the comments link in your own so that the conversation can be more easily followed (in absence of threaded conversation support in Github). This should be done on the first line of the comment via **RE: <url>**
Capabilities and API
- [ ] ARIA support
- [ ] ...
Tasks Adding them here until issues are created
- Update documentation for each change
- Complete review of documentation against capabilities
Issues tracking these efforts
https://github.com/softlayer/sl-ember-components/issues?q=is%3Aopen+is%3Aissue+milestone%3A%22v0.13.0+%28Final+push+for+a+1.0.0+release%29%22+label%3Asl-chart
PROPOSAL We should allow options to be set even after the initial chart render, for cases when the options depend on the data
Specific use case: I'm using plotbands to show an uptime meter in the background while graphing data at the same time.
PROPOSAL
Remove this component from this addon.
There are other addons, such as https://github.com/aomran/ember-cli-chart, which already provide charting solutions and ours is not providing any value-add to these.
The reason the sl-chart component originally exists in this repo is because SoftLayer uses HighCharts in its customer portal, so we made an Ember wrapper for this. But this does not fit with the spirit of this addon. If we are going to provide charting capabilities in this addon it should be via a license-free charting solution. As soon as these solutions begin to be researched several things are obvious: 1) there is a lot of functionality that should be offered, 2) there are other addons already offering this, and 3) maintaining this one component could become a project unto itself (which the existence of dedicated addons for this proves that it is) and this effort is not worth it as we do not have a better way of providing charting capabilities nor is there any integration with the rest of the components in this addon that is needed.
RE: https://github.com/softlayer/sl-ember-components/issues/1254#issuecomment-186251700
I am :+1: for removing this component.
