sl-ember-components icon indicating copy to clipboard operation
sl-ember-components copied to clipboard

Unexpected CSS token

Open notmessenger opened this issue 9 years ago • 5 comments

What is described in https://github.com/FortAwesome/Font-Awesome/issues/5043 is occurring in Safari Version 9.0 (10601.1.56.2) on OS X Yosemite 10.10.5 (14F27)

notmessenger avatar Oct 28 '15 13:10 notmessenger

@notmessenger so this issue is a bit weird, I fixed it when I do a bower install and have the bower components folder in my local directory but there is no way to actually hot fix the source code of font-awesome. we can do 2 things, wait until it gets bundled into a new version of font awesome and update the dependency or fork font-awesome and reference our forked fixed version. If I'm missing something let me know, thanks

erangeles avatar Jan 26 '16 15:01 erangeles

Or, we can possibly bower install font-awesome --save-dev, and modify ember-cli-build.js to do less compile. We could then add a less file inside the dummy app that overrides the mixin at fault.

I was attempting to do this, but hit a brick wall. Can't figure out the ember-cli-build.js file vs the index.js

SpikedKira avatar Feb 10 '16 19:02 SpikedKira

Does this ever occur in an consuming app or is it only ever in the dummy app of this repo? If it never occurs in the consuming app I'm not worried about it and will close this issue.

notmessenger avatar Feb 10 '16 22:02 notmessenger

dummy app only

SpikedKira avatar Feb 11 '16 15:02 SpikedKira

Moving to the v1.0.0 milestone which is for the redevelopment of the demo application. Can likely be closed at that point.

notmessenger avatar Feb 11 '16 15:02 notmessenger