BestViewDistance
BestViewDistance copied to clipboard
sofianedjerbi
Paper 1.14.x errors
Describe the bug Console errors when join, using command and periodically
To Reproduce Steps to reproduce the behavior:
- Run server with BVD and depencies
- Join to server
- Wait
Expected behavior Work without errors
Timings No need
Additional context Paper 1.14.3 build 119 BVD dev build 35 Errors: https://pastebin.com/JFkb2PSk
And update dev builds link
It seems that it comes from Paper. We'll need to wait for an update.
Z750 (Paper Developer) :
It comes from paper API isn’t in 1.14.x and requires a deeper understanding of Mojangs rewrite of the chunk system to implement "Okay, thanks. Are you planning to get this API compatible with 1.14 ?" It’s planned There are no ETAs
Maybe implement a more graceful way that detects Paper on 1.14.3 and prevents calling those APIs? This spams the server log quite a lot.
I am aware this is an issue from Paper itself, but seeing how this won't be implemented anytime soon (by the looks of it), perhaps a workaround is in order.
Maybe implement a more graceful way that detects Paper on 1.14.3 and prevents calling those APIs? This spams the server log quite a lot.
I am aware this is an issue from Paper itself, but seeing how this won't be implemented anytime soon (by the looks of it), perhaps a workaround is in order.
Added in commit f9cdc11
@Kugge Just to confirm, does this mean that BestViewDistance is broken on 1.14.3?
The commit disables it, I assume this is because it has no benefit without the per-player view distance APIs?
I thought it still set the global server view distance based on TPS/ping etc.
@Ristovski The API provided by paper allow BVD to change the view distance, and that API is broken on 1.14.X. BVD cannot change view distance at all so it's 100% useless on 1.14.X
I see, I thought some of the functionality (like global view distance based on TPS/etc) was still there. Good to know.
the re-implementation of the patch has reached a good point where we can start external testing https://github.com/PaperMC/Paper/pull/2572
this implements per player view distance at the ticket level, allowing more functionality and allowing shared view distance.
any testing would be much appreciated, that way we can get merged faster :))
Managed to get it working, seems good so far! Here is my modified plugin https://sc.azureedge.net/BestViewDistance-12.1-MAJN.jar
Will report if anything breaks :) Thank you @SlickJava
just remember to keep the jar as updated as possible to the latest one on the PR (the latest one now built off of 209 with many fixes), other than that, happy testing
Running @SlickJava's patch + the latest paper version that I merged myself. The one huge problem I'm facing is my render distance is at 3, despite 20TPS. Not sure if this a bug, incompatibility, or misconfiguration.
Try running my patched version. This plugin will not work correctly in 1.14 without slight modifications.
Interesting... Please add me on Discord Škýl#0001. I don't want to overly spam here (I will edit this comment with solution to this problem).
EDIT: figured out it was his Ping setting
Hello do you have new for update into 1.14 or 1.15 ? This plugin is very usefull on my server On paper the PR https://github.com/PaperMC/Paper/pull/2572 was closed by author @SlickJava So what's next?
Hello do you have new for update into 1.14 or 1.15 ? This plugin is very usefull on my server On paper the PR PaperMC/Paper#2572 was closed by author @SlickJava So what's next?
I'm curious too! :D
@Kugge Your plugin work with Tuinity 1.15.2 https://ci.codemc.io/job/Spottedleaf/job/Tuinity/
@jewome62
@Kugge Your plugin work with Tuinity 1.15.2 https://ci.codemc.io/job/Spottedleaf/job/Tuinity/
Which build?
