Exception not logged when get connection throw exception
Describe the bug
Actually, this is not a bug. In our pro environment, we find lots of 'get connection failed in url' log in transport.log file, but we can't figure out what exception it is because the exception is not logged, as blow:
ReuseBoltClientConnectionManager.java
try { connection = rpcClient.getConnection(url, url.getConnectTimeout()); } catch (Exception e) { LOGGER.warn("get connection failed in url," + url); }
Suggestion: log the exception cause we don't know what happen without enough exception info.
Expected behavior
Actual behavior
Steps to reproduce
Minimal yet complete reproducer code (or GitHub URL to code)
Environment
- SOFARPC version: 6.2.0
- JVM version (e.g.
java -version): jdk 1.8 - OS version (e.g.
uname -a): linux centos 7 - Maven version:
- IDE version:
If it is helpful for troubleshooting, detailed logs can be added.
PR #1243
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.