sofa-ark icon indicating copy to clipboard operation
sofa-ark copied to clipboard

MainMethodRunner 中对于 envs 的处理是否可以直接复用 koupleless 中的 MultiBizProperties

Open shichaoyuan opened this issue 1 year ago • 2 comments

Feature description

https://github.com/sofastack/sofa-ark/blob/feeae5d04160c1b7a99afbc6ad84aae50f33fe03/sofa-ark-parent/core-impl/archive/src/main/java/com/alipay/sofa/ark/bootstrap/MainMethodRunner.java#L52-L56

koupleless 的 MultiBizProperties 提供了基于 classloader 的系统属性隔离,是否可以将该机制复用到 sofa-ark 中实现 envs 的隔离?

Additional notes

相关PR https://github.com/koupleless/koupleless/pull/58

shichaoyuan avatar Jun 27 '24 06:06 shichaoyuan

可以的,env 不一定一定要通过 jvm层面的多租户解决,只要在上一层有一个逻辑的隔离就可以的。 MultiBizProperties 是一种可行的实现方式。不用 MultiBizProperties (避免污染 properties) 也可以用别的来实现,例如 namespace、prefix 等。

lvjing2 avatar Jun 27 '24 06:06 lvjing2

可以的,env 不一定一定要通过 jvm层面的多租户解决,只要在上一层有一个逻辑的隔离就可以的。 MultiBizProperties 是一种可行的实现方式。不用 MultiBizProperties (避免污染 properties) 也可以用别的来实现,例如 namespace、prefix 等。

希望社区给一个建议实现,在sofa-ark这一层解决掉。

shichaoyuan avatar Jun 27 '24 07:06 shichaoyuan

This issue has been automatically marked as stale because it has not had recent activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue or help wanted) or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 28 '24 02:07 github-actions[bot]

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue or help wanted. Thank you for your contributions.

github-actions[bot] avatar Aug 04 '24 02:08 github-actions[bot]

@lvjing2 I'm interested in this. Please assign it to me.

oxsean avatar Aug 10 '24 08:08 oxsean

This issue has been automatically marked as stale because it has not had recent activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue or help wanted) or other activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 10 '24 02:09 github-actions[bot]

already fixed

lvjing2 avatar Sep 24 '24 12:09 lvjing2