sofa-ark icon indicating copy to clipboard operation
sofa-ark copied to clipboard

Embed Mode: support embedPlugin class isolation

Open gaosaroma opened this issue 2 years ago • 2 comments

Motivation:

  • support embedPlugin class isolation for common biz with PLUGIN_CLASSLOADER_ENABLE=true && PLUGIN_CLASS_EXPORT_ENABLE=true mode.
  • add unit test for class isolation.

Modification:

  • modify pluginFactoryServiceImp#createEmbedPlugin

Result:

Fixes #496 .

gaosaroma avatar Jun 20 '22 13:06 gaosaroma

Codecov Report

Merging #530 (e91eb7a) into master (27df24d) will increase coverage by 0.47%. The diff coverage is 93.33%.

@@             Coverage Diff              @@
##             master     #530      +/-   ##
============================================
+ Coverage     59.67%   60.15%   +0.47%     
- Complexity      678      694      +16     
============================================
  Files           154      154              
  Lines          5858     5870      +12     
  Branches        845      848       +3     
============================================
+ Hits           3496     3531      +35     
+ Misses         2037     2022      -15     
+ Partials        325      317       -8     
Impacted Files Coverage Δ
...va/com/alipay/sofa/ark/spi/constant/Constants.java 0.00% <ø> (ø)
...pay/sofa/ark/support/startup/SofaArkBootstrap.java 25.71% <ø> (ø)
...ainer/service/plugin/PluginFactoryServiceImpl.java 91.15% <92.30%> (+1.83%) :arrow_up:
...ofa/ark/support/startup/EmbedSofaArkBootstrap.java 84.84% <100.00%> (+0.97%) :arrow_up:
...m/alipay/sofa/ark/container/model/PluginModel.java 94.94% <0.00%> (+1.01%) :arrow_up:
.../container/service/classloader/BizClassLoader.java 84.70% <0.00%> (+1.17%) :arrow_up:
.../service/extension/ExtensionLoaderServiceImpl.java 90.00% <0.00%> (+1.25%) :arrow_up:
.../com/alipay/sofa/ark/container/model/BizModel.java 76.50% <0.00%> (+2.18%) :arrow_up:
...ofa/ark/container/pipeline/HandleArchiveStage.java 42.57% <0.00%> (+10.89%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27df24d...e91eb7a. Read the comment docs.

codecov[bot] avatar Jun 24 '22 04:06 codecov[bot]

其它问题:对于示例:SOFABoot 应用基于 SOFAArk 的动态模块,在embed模式开启类隔离的使用中,需要其依赖runtime-sofa-boot-plugin设置属性<delegateToEmbedBase>true</delegateToEmbedBase>;或许PR完成后再给runtime-sofa-boot-plugin提issue?

gaosaroma avatar Jun 28 '22 08:06 gaosaroma

该 PR 还需要再充分讨论一下,暂时不合并,待 5 月份重新讨论再决定 close 还是 approve。

lylingzhen avatar Mar 20 '23 03:03 lylingzhen

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Oct 28 '23 02:10 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Nov 04 '23 02:11 github-actions[bot]