Stephen O'Donnell

Thanks for updating the formatting. I have a few more comments around code reuse and also a possible bug to check on. Also a conflict has appeared against one class...

One other thing I spotted: ``` "TrackedPipelinesWaitingToCloseTotal" : 2, "TrackedRecommissionNodesTotal" : 0, "trackedPipelinesWaitingToClose-ozone-datanode-3.ozone_default" : 0, "trackedSufficientlyReplicated-ozone-datanode-3.ozone_default" : 0, "trackedUnderReplicated-ozone-datanode-3.ozone_default" : 0, "trackedUnhealthyContainers-ozone-datanode-3.ozone_default" : 0, ``` The host level metrics start...

Why use threadLocal variables in the latest patch? Does this even work? If another thread reads the values set by the monitor thread, does it even get the values, as...

ThreadLocal should not be needed for this. I feel there is probably a simpler solution we can use, but I would need to see the original error first.

I took the code you have pushed here, reverted the last commit and implemented some changes to make it simpler and fix the synchronization issue. Please have a look here:...

I'm out of the office this week. I will look at this again on Monday. I don't think this PR is essential for the 1.3 release as we have lived...

> Now, a single metric name is used for the same metric collected for each datanode, within the metric is an associated tag that identifies the node for the metric...

``` "tag.datanode.1" : "ozone-datanode-3.ozone_default", "tag.Hostname.1" : "39160451dea0", "TrackedUnderReplicatedDN.1" : 1, "tag.datanode.2" : "ozone-datanode-3.ozone_default", "tag.Hostname.2" : "39160451dea0", "TrackedSufficientlyReplicatedDN.2" : 0, "tag.datanode.3" : "ozone-datanode-3.ozone_default", "tag.Hostname.3" : "39160451dea0", "TrackedPipelinesWaitingToCloseDN.3" : 0, "tag.datanode.4" :...

Yes it makes sense to open a new Jira for the prometheus issue. The tagged metrics look better now - we have one tag per DN, which is what I...

Latest changes look good. Please have a check @kerneltime and we can commit if you are happy.