radash icon indicating copy to clipboard operation
radash copied to clipboard

Drop support for node v12

Open sodiray opened this issue 3 years ago • 1 comments

Based on chat with @matteosacchetto in #108 we'll drop support for node 12 after node v18 becomes LTS on 2022-10-25. This will be a major version bump to 9.0.0.

Screen Shot 2022-10-18 at 9 35 28 AM

See Node release calendar here.

sodiray avatar Oct 18 '22 16:10 sodiray

I would also suggest, already for release 8.0.0, adding to the package JSON the detail about the minimum supported node version, with the engines property. Reference here

Example:

{
  ...,
  "engines": {
    "node": ">=12.22.12"
  }
}

12.22.12 is the LTS version used in the test runners github actions

matteosacchetto avatar Oct 18 '22 18:10 matteosacchetto

shouldn't you change the ci test versions too?

  ...
  node-version: [14.x, 16.x, 18.x]

MarlonPassos-git avatar Oct 22 '22 23:10 MarlonPassos-git

Yes. When we will drop support for v12 there will be changes regarding Rollup, tsconfig, the ci tests and the engine specified in the package.json

As soon as node 18 lands as an LTS il will do a PR with those changes

matteosacchetto avatar Oct 23 '22 06:10 matteosacchetto