nbp icon indicating copy to clipboard operation
nbp copied to clipboard

[CSI] Missing unit test and functional test in csi module

Open leonwanghui opened this issue 5 years ago • 5 comments

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened: I found there is a csi-test project located in kubernetes-csi code repo, I think it's required to import that project into csi module and trigger that in ci environment.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?: @xing-yang Please take a look at that project.

Environment:

  • NBP version:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

leonwanghui avatar Apr 25 '19 01:04 leonwanghui

@leonwanghui Yes, it is good to use csi-test to test CSI plugin. It validates that a CSI plugin implementation follows CSI spec. We should add this task.

xing-yang avatar Apr 25 '19 02:04 xing-yang

@wisererik

xing-yang avatar Apr 25 '19 02:04 xing-yang

Here are instructions on how to use the sanity test package to test CSI drivers: https://github.com/kubernetes-csi/csi-test/tree/master/pkg/sanity

xing-yang avatar Apr 25 '19 02:04 xing-yang

Sure, I saw that, @jackhaibo please add test for CSI

wisererik avatar Apr 25 '19 04:04 wisererik

@wisererik @jackhaibo any update on this?

skdwriting avatar Jun 13 '19 06:06 skdwriting