delfin icon indicating copy to clipboard operation
delfin copied to clipboard

Remove the redundant __init__ function in class AlertHandler

Open UtkarshShah0 opened this issue 2 years ago • 4 comments

What this PR does / why we need it: Removed the redundant init function in class AlertHandler.

Which issue this PR fixes: fixes #887

Special notes for your reviewer: SODACODE 2022 thanks

UtkarshShah0 avatar Apr 28 '22 14:04 UtkarshShah0

Codecov Report

Merging #896 (d7817d4) into master (0272eed) will increase coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   70.47%   70.49%   +0.02%     
==========================================
  Files         181      181              
  Lines       19055    19053       -2     
  Branches     2812     2812              
==========================================
+ Hits        13429    13432       +3     
+ Misses       4756     4754       -2     
+ Partials      870      867       -3     
Impacted Files Coverage Δ
...rs/dell_emc/vmax/alert_handler/unisphere_alerts.py 33.33% <ø> (-0.88%) :arrow_down:
delfin/drivers/fake_storage/__init__.py 94.65% <0.00%> (+1.01%) :arrow_up:

codecov[bot] avatar Apr 28 '22 14:04 codecov[bot]

Updated title to meaning full text

joseph-v avatar Apr 29 '22 03:04 joseph-v

@skdwriting Please review and approve. One more approval required.

UtkarshShah0 avatar Apr 30 '22 13:04 UtkarshShah0

LGTM

#SODA-PR-ACCEPTED

Based on @joseph-v approval

anvithks avatar Apr 30 '22 19:04 anvithks