soda-core icon indicating copy to clipboard operation
soda-core copied to clipboard

Add support failed rows query in user defined metric check

Open sagarwal144 opened this issue 1 year ago • 2 comments

Currently, we don't have a way to specify the failed row query in the user defined metric. So when the user defined metric check fails, we are not able to collect the sample failed rows in either SODA Cloud or CustomSampler. This issue proposes to add failed row query section in the user defined metric as follows

- test_metric_query = 0:
      test_metric_query query: |
        SELECT count(*)
        FROM group_subs where start_date > end_date
      fail query: |
        SELECT id, start_date, end_date
        FROM group_subs where start_date > end_date
        LIMIT 5

sagarwal144 avatar Mar 22 '24 22:03 sagarwal144

SAS-3109

tools-soda avatar Mar 22 '24 22:03 tools-soda

Hi, thanks for your request! This feature will added early May.

benjamin-pirotte avatar Mar 26 '24 09:03 benjamin-pirotte

Hi, sorry for the delay, but the feature has been added. See last option in https://docs.soda.io/soda-cl/user-defined.html#optional-check-configurations

benjamin-pirotte avatar Jun 27 '24 13:06 benjamin-pirotte

Thanks for adding this feature!

From: @.*** At: 06/27/24 09:55:38 UTC-4:00To: @.*** Cc: Saurabh Agarwal (BLOOMBERG/ 731 LEX ) , @.*** Subject: Re: [sodadata/soda-core] Add support failed rows query in user defined metric check (Issue #2044)

Hi, sorry for the delay, but the feature has been added. See last option in https://docs.soda.io/soda-cl/user-defined.html#optional-check-configurations
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

sagarwal144 avatar Jun 27 '24 14:06 sagarwal144

Added in #2089

m1n0 avatar Jun 27 '24 14:06 m1n0