soda-core icon indicating copy to clipboard operation
soda-core copied to clipboard

Change percent logic is a failure condition, which is reverse from the norm

Open guxie opened this issue 2 years ago • 1 comments

- change percent for row_count > 50% The condition above is meant to fail anything that is NOT above the 50% threshold. All other checks are designed to indicate the success condition, where this is a definition of a failure condition.

I'd recommend updating it such that the above change percent check is specifically as a success condition, which is the norm in other checks.

guxie avatar Aug 16 '22 23:08 guxie

I agree, the thread we were troubleshooting on offers a little more context, but both of us had to stop and think and test to validate the logic to really understand it. Would be good to have a completely consistent paradigm of setting pass state.

janet-can avatar Aug 17 '22 15:08 janet-can