soda-core icon indicating copy to clipboard operation
soda-core copied to clipboard

Provide error when `set_scan_definition_name` is not set but SodaCloud config is set

Open jasonicarter opened this issue 2 years ago • 0 comments

When programmatically triggering scans, you are required to set the scan definition name ONLY if you are sending data to SodaCloud. However, if you do have SodaCloud configured and do not set_scan_definition_name you receive no error message and it completes "successfully" without sending data to Soda Cloud.

https://github.com/sodadata/soda-core/blob/main/soda/core/soda/scan.py#L56

from soda.scan import Scan
scan = Scan()
scan.set_scan_definition_name("my_def_name")
...
scan.execute()

Documentation didn't mention this either.

jasonicarter avatar Apr 05 '22 18:04 jasonicarter