soda-java icon indicating copy to clipboard operation
soda-java copied to clipboard

Soda2Consumer should not require username and password, specify token should be enough

Open bowenli86 opened this issue 8 years ago • 4 comments

Why Soda2Consumer require username and password? Shouldn't providing token is enough? If I interact with the server via http, token is the only thing I need

bowenli86 avatar Feb 13 '17 06:02 bowenli86

You can use the constructor that just takes a base URL: https://github.com/socrata/soda-java/blob/270269d3eb4f4e64169801cbd3c2aade523bc2d9/src/main/java/com/socrata/api/Soda2Consumer.java#L28

Would that work for you instead?

chrismetcalf avatar Feb 13 '17 23:02 chrismetcalf

Not really. According to section 'Throttling and Application Tokens' in https://dev.socrata.com/consumers/getting-started.html, if developers don't specify a token, there'll be throttling of app's requests.

bowenli86 avatar Feb 13 '17 23:02 bowenli86

Are you ok if I submit a PR to add another constructor, which only requires url and token, to Soda2Consumer?

bowenli86 avatar Feb 18 '17 01:02 bowenli86

@bowenli86 Sorry for not following up sooner, but of course a pull request would be welcome.

FYI, within the next day or two I'll be merging https://github.com/socrata/soda-java/pull/27, which should dramatically clean up running the tests and such, and will introduced TravisCI testing to our workflow as well. Long overdue.

chrismetcalf avatar Mar 22 '17 01:03 chrismetcalf