sockjs-client icon indicating copy to clipboard operation
sockjs-client copied to clipboard

When possible, set the Accept header appropriately

Open candrews opened this issue 3 years ago • 3 comments

When the transport supports doing so, set the "Accept" request header to an appropriate value. Doing so informs the server what type of response the client is expecting.

Closes https://github.com/sockjs/sockjs-client/issues/540

candrews avatar Apr 05 '21 17:04 candrews

The failing test is because the test doesn't have access to Travis secure variables: https://github.com/sockjs/sockjs-client/blob/ddae5a3eb1f482e2628977d3473ec4f3eea99bf2/build.sh#L7

It would pass if run by the main sockjs-client repo.

candrews avatar Apr 05 '21 18:04 candrews

@brycekahle can you please take a look at this PR?

candrews avatar May 03 '21 00:05 candrews

@candrews Apologies. I'll take a look at this soon. I just need to verify the Accept values are valid in all cases.

brycekahle avatar Aug 24 '21 17:08 brycekahle