bug: application_icon_config is not getting templated on android build

[No9]

What OS are you using (uname -a, or Windows version)?

6.2.0-39-generic https://github.com/socketsupply/socket/pull/40~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Nov 16 10:53:04 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

What version Socket Runtime are you using?

0.5.4 (f90ba121) Installation path: /home/anton/.local/share/socket/

What programming language are you using (C/C++/Go/Rust)?

gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0

Ubuntu clang version 14.0.0-1ubuntu1.1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

What did you expect to see and what you saw instead?

Default project ssc init should build and run on android with ssc build --platform=android -c -p.

Project fails to build with this error

ssc build -r -o --platform=android
• package prepared +2466ms
[=======================================] 100% Computing updates...             


> Configure project :app
WARNING:The option setting 'android.experimental.legacyTransform.forceNonIncremental=true' is experimental.
The current default is 'false'.

> Task :app:processDevDebugMainManifest FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processDevDebugMainManifest'.
> com.android.manifmerger.ManifestMerger2$MergeFailureException: Error parsing /home/anton/code/sockapp/build/android/app/src/main/AndroidManifest.xml

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 900ms
6 actionable tasks: 1 executed, 5 up-to-date
• ERROR: failed to invoke ./gradlew :app:bundleDebug --warning-mode all command. +2609ms

The file /home/anton/code/sockapp/build/android/app/src/main/AndroidManifest.xml has malformed XML.

<application
    android:allowBackup="true"
    android:label="sockapp"
    android:theme="@style/Theme.AppCompat.Light"
    android:supportsRtl="true"
    {{android_application_icon_config}}
    android:usesCleartextTraffic="true"

  >

Setting the application_icon_config value in the [android] section in socket.ini file gets passed this issue and the app deploys successfully.

[android]
; The icon to use for identifying your app on Android.
icon = "src/icon.png"

application_icon_config=""

Also note the icon.png in the project is not picked up and the default android icon is used in the deployed app which is also unexpected and might be a clue as to what is happening here.

Adding @jwerle as it looks like this PR is aiming to resolve this https://github.com/socketsupply/socket/pull/864/files ?

[jwerle]

Hmm, this should have been fixed, but it appears it not to be working on linux! We'll get this fixed ASAP

[developmentforpeople]

Hi there, still happens to me using Ubuntu, and makes impossible to get Android apps using Linux. Thanks for your excellent work! FYI: @chicoxyzzy @heapwolf