bug: Install with curl fails to detect required deps

[No9]

Hey all, Just taking ssc for a night time drive and came across this. I'm not blocked but thought it might be of interest.

What OS are you using (uname -a, or Windows version)?

6.2.0-39-generic #40~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Nov 16 10:53:04 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

What version Socket Runtime are you using?

0.5.4 (f90ba121) Installation path: /home/anton/.local/share/socket/

What programming language are you using (C/C++/Go/Rust)?

gcc --version gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0

What did you expect to see and what you saw instead?

This is a fairly clean ubuntu 22.04 install so I expected an error free install. However I got the following issues so I thought I'd report it.

1. Ran . <(curl -s -o- https://socketsupply.co/sh)

2. Initial install failed with

   #   __   ___  ___      ___ ____ 
   #  /__  /  / /   /_/  /__   /   
   #  __/ /__/ /__ /  \ /__   /    
   # 
   # getting files...
   warn - using '/home/anton/.local/share/socket' as SOCKET_HOME
   warn - Installing to '/usr/local'
   not ok - missing build tools, try "sudo apt install clang-14"
   

3. Ran sudo apt install clang-14

4. Reran . <(curl -s -o- https://socketsupply.co/sh) got further in the build but failed with

   ...
   # compiling object (arm64-v8a-android) version.c
   ok - built threadpool.c -> threadpool.o (arm64-v8a-android)
   ok - built timer.c -> timer.o (arm64-v8a-android)
   ok - built uv-data-getter-setters.c -> uv-data-getter-setters.o (arm64-v8a-android)
   ok - built version.c -> version.o (arm64-v8a-android)
   ok - built uv-common.c -> uv-common.o (x86_64-android)
   ok - built libuv (x86_64-android): libuv.a
   ok - built uv-common.c -> uv-common.o (arm64-v8a-android)
   ok - built libuv (arm64-v8a-android): libuv.a
   In file included from <stdin>:1:
   In file included from /home/anton/socket/socket/socket/src/core/core.hh:6:
   In file included from /home/anton/socket/socket/socket/src/core/debug.hh:5:
   /home/anton/socket/socket/socket/src/core/platform.hh:37:10: fatal error: 'JavaScriptCore/JavaScript.h' file not found
   #include <JavaScriptCore/JavaScript.h>
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
   not ok - /usr/lib/llvm-14/bin/clang++ (14.0.0) failed in feature check required for building Socket Runtime - please report (https://discord.gg/YPV32gKCsH)
   

5. Did some splunking around the build scripts as I thought it was weird that CI isn't failing. Noticed that you are manually installing webkit and other things https://github.com/socketsupply/socket/blob/ab91cfa3a942f224fe96c4be59bbc08ece80852a/.github/workflows/ci.yml#L284

6. Ran sudo apt install libpthread-stubs0-dev libwebkit2gtk-4.1-dev at-spi2-core

7. Successfully built but got these stat errors at the end

   cp: cannot stat '/home/anton/socket/build/arm64-v8a-android/pkgconfig/*': No such file or directory
   cp: cannot stat '/home/anton/socket/build/x86_64-android/pkgconfig/*': No such file or directory
   # moving binary to '/home/anton/.local/share/socket/bin' (prompting to copy file into directory)
   # linking binary to /usr/local/bin/ssc
   warn - Failed to link binary to '/usr/local/bin': Trying 'sudo'
   ok - done. type 'ssc -h' for help
   

8. scc init and scc build -r complete successfully.

9. Looking at the bash scripts it seems like these deps should be installed or should the docs be updated to reflect CI?