io-event icon indicating copy to clipboard operation
io-event copied to clipboard

Fix build error with Ruby 3.1 on Windows

Open Watson1978 opened this issue 1 year ago • 2 comments

Since Ruby 3.2, pipe function declaration is provided in https://github.com/ruby/ruby/blob/21c708ee802e1a59901eccc6448e40e8f72189b8/include/ruby/missing.h#L292 However, it does not provided it with Ruby 3.1.

This patch will define pipe macro to use proper function due to fix build error.

Types of Changes

  • Bug fix.

Fix https://github.com/socketry/io-event/issues/111

Contribution

Watson1978 avatar Aug 21 '24 06:08 Watson1978

I may need to review the test failures, it may be unrelated to the PR. I'll try to take a look shortly.

ioquatix avatar Aug 21 '24 11:08 ioquatix

Thanks

Watson1978 avatar Aug 21 '24 11:08 Watson1978

This is a good start to better windows support. Thanks.

ioquatix avatar Oct 03 '24 23:10 ioquatix

I have released v1.7.0 which works with Windows, tested on Ruby v3.1+.

For better compatibility, we should work on https://github.com/socketry/io-event/pull/97.

ioquatix avatar Oct 04 '24 00:10 ioquatix

Thanks!

Watson1978 avatar Oct 04 '24 00:10 Watson1978