falcon icon indicating copy to clipboard operation
falcon copied to clipboard
verified publisher icon socketry

Make restart an option

Open swlkr opened this issue 3 years ago • 1 comments

When using falcon serve the controller keeps restarting the process if there is a syntax error.

This commit adds a --restart false option to falcon serve so that it doesn't restart repeatedly.

This keeps the default restart: true behavior.

Types of Changes

  • Bug fix.

Testing

  • [ ] I added tests for my changes.
  • [x] I tested my changes locally.

swlkr avatar May 20 '22 18:05 swlkr

Thanks for this.

I think this can be a good addition.

I'm actually considering better handling of container startup failure.

There is a difference between failed to start up and failed later on.

We should know the difference and act accordingly.

ioquatix avatar May 21 '22 01:05 ioquatix

Added here: https://github.com/socketry/falcon/commit/9fcd82167e6d55e85c21ba4b04220576cc024dcb

Thanks for your suggestion and proposed code changes.

ioquatix avatar Mar 28 '24 13:03 ioquatix