async icon indicating copy to clipboard operation
async copied to clipboard

Published 20 hours ago • verified publisher icon socketry

Run tests on Windows.

Open ioquatix opened this issue 3 years ago • 5 comments
trafficstars

This is an experimental PR to see how badly Windows fails.

Types of Changes

  • New feature.

Testing

  • [ ] I added tests for my changes.
  • [ ] I tested my changes locally.
  • [ ] I tested my changes in staging.
  • [ ] I tested my changes in production.

ioquatix avatar Oct 13 '22 11:10 ioquatix 

101 passed 1 failed 118 errored out of 220 total (257 assertions)

ioquatix avatar Dec 06 '22 10:12 ioquatix

@larskanis not sure if you are interested to help on this, but the recent changes for UNIXSocket have made this easier.

ioquatix avatar Dec 06 '22 11:12 ioquatix

@ioquatix I made some small changes and it seems to work.

larskanis avatar Dec 07 '22 18:12 larskanis

@larskanis should we make IO on windows non-blocking by default where possible? It's already the default on Linux.

ioquatix avatar Dec 07 '22 22:12 ioquatix

https://github.com/ruby/ruby/pull/6874

ioquatix avatar Dec 07 '22 22:12 ioquatix