async-http-faraday icon indicating copy to clipboard operation
async-http-faraday copied to clipboard
verified publisher icon socketry

use VCR for spec that is calling remote server

Open binarycode opened this issue 5 years ago • 1 comments

This PR wraps the 'can get remote resource' spec in VCR cassette, so that no external dependencies are needed to run the specs.

One issue though is that the VCR does not support the close method introduced in Faraday v1.0.0, so I had to monkeypatch it until the PR https://github.com/vcr/vcr/pull/793 is merged.

binarycode avatar Feb 01 '20 11:02 binarycode

Thanks for your effort. I need to review whether this is the right approach. While I understand the need for fast and reproducible, end-to-end testing is also important.

ioquatix avatar Feb 01 '20 13:02 ioquatix