socket.io icon indicating copy to clipboard operation
socket.io copied to clipboard

Adapter method should return a Promise | void

Open zackliu opened this issue 1 year ago • 2 comments

Is your feature request related to a problem? Please describe. Some Adapter method return void only that make customized adapter implementer have trouble on implementing. E.g. io.socketsJoin() and inner adapter's method addSockets and delSockets currently return void which brings troubles for new adapter implementer as the adapter may not be able to do it synchronized.

Describe the solution you'd like Return Promise | void instead of void and thus let adapter implementer decide whether it should be async.

zackliu avatar Aug 08 '23 03:08 zackliu

Can I work on this?

NextThread avatar Aug 29 '23 05:08 NextThread

This is probably related to https://github.com/socketio/socket.io/issues/4734 and I'd love to see it fixed.

dhardtke avatar Mar 20 '24 21:03 dhardtke