socket.io-website icon indicating copy to clipboard operation
socket.io-website copied to clipboard

Server Delivery tutorial is missing things

Open mikebourbeauart opened this issue 2 years ago • 2 comments

https://socket.io/docs/v4/tutorial/step-7

This tutorial doesn't provide code to create the "Disconnect" button in order to test things out. It's simple enough to get past that part, but it's not clear how I'd hook this up to test out disconnection.

mikebourbeauart avatar Nov 17 '23 05:11 mikebourbeauart

H! Thanks a lot for the feedback :+1:

I've added the code for the "Disconnect" button in the tutorial: https://socket.io/docs/v4/tutorial/step-6

darrachequesne avatar Nov 17 '23 10:11 darrachequesne

It works, thank you!

I do have 1 suggestion though: From what I've seen in the tutorial so far the code isn't usually tucked away inside a collapsed admonition. Since it's required code for the next sections it probably shouldn't be collapsed by default (so people don't accidentally miss it) or maybe it's taken out of the admonition since it seems like most code isn't within one to begin with.

mikebourbeauart avatar Nov 17 '23 13:11 mikebourbeauart