socket.io-redis-streams-adapter icon indicating copy to clipboard operation
socket.io-redis-streams-adapter copied to clipboard
verified publisher icon socketio

feat: add support of node_redis 5

Open AndrijVasyliev opened this issue 4 months ago • 4 comments

AndrijVasyliev avatar Jul 21 '25 11:07 AndrijVasyliev

Legendary

tj-mc avatar Jul 28 '25 06:07 tj-mc

Probably I miss something, that I must accomplish for this PR be merged? I will be most gratefull if someone points at those things.

AndrijVasyliev avatar Aug 20 '25 10:08 AndrijVasyliev

yea, this seems to work perfectly. Be nice if the maintainer would merge this or otherwise provide some direction. TIA

june07 avatar Oct 13 '25 21:10 june07

Hi, sorry for the delay.

Unfortunately, I don't think this works with a Redis cluster, as we need isolated pools (commandOptions({ isolated: true }) in v4, client.createPool() in v5), so that client.xread() does not block client.xadd() operations.

References:

  • https://github.com/redis/node-redis/blob/master/docs/pool.md
  • https://github.com/redis/node-redis/blob/master/docs/clustering.md

Possibly related: https://github.com/redis/node-redis/issues/2928

darrachequesne avatar Oct 15 '25 08:10 darrachequesne