TLSharp icon indicating copy to clipboard operation
TLSharp copied to clipboard

GetFullChat + GetAllChats + MakeAuthBotAsync + Other methods

Open solarin opened this issue 4 years ago • 5 comments

  • GetFullChat to get the info of a chat
  • GetAllChats to get all available user's chats
  • MakeAuthBotAsync to authenticate a bot instead of a user

solarin avatar Apr 03 '20 13:04 solarin

You need to remove the DataCenterIPVersion stuff from here, otherwise the PRs are not separate (if I merge the other one, there will be conflicts here).

knocte avatar Apr 03 '20 14:04 knocte

You need to remove the DataCenterIPVersion stuff from here, otherwise the PRs are not separate (if I merge the other one, there will be conflicts here).

ok i think it's ok now

solarin avatar Apr 03 '20 16:04 solarin

@aarani can you review this PR?

knocte avatar Apr 05 '20 12:04 knocte

@knocte as for the Array.ForEach, the only replacement i am aware of is to do a classic for(int i...). i wouldn't use any other list in this case as they would introduce a worse overhead than the Array.ForEach.

solarin avatar Apr 06 '20 07:04 solarin

as for the Array.ForEach, the only replacement i am aware of is to do a classic for(int i...). i wouldn't use any other list in this case as they would introduce a worse overhead than the Array.ForEach.

Let's use a normal foreach then. More reasoning here: https://docs.microsoft.com/en-gb/archive/blogs/ericlippert/foreach-vs-foreach

knocte avatar Apr 06 '20 08:04 knocte