quill-better-table icon indicating copy to clipboard operation
quill-better-table copied to clipboard

Integrate the tool of inserting table into the toolbar module of quill (Fix #34)

Open simialbi opened this issue 4 years ago • 4 comments

I built a module out of Rudy's solution and tried to do like official Quill Pickers. The integration was not possible without extending the Snow Theme. The solution looks like this: image

Usage

var quill = new Quill("#quill-div", {
    "theme": "better-table-snow",
    "modules": {
        "better-table": [],
        "keyboard": {
            "bindings": quillBetterTable.keyboardBindings
        },
        "toolbar": [
            ["clean"],
            [{
                "list": "ordered"
            }, {
                "list": "bullet"
            }],
            [{
                "indent": "-1"
            }, {
                "indent": "+1"
            }],
            ["bold", "italic", "underline", "strike", {
                "script": "super"
            }, {
                "script": "sub"
            }],
            ["link", {
                "better-table": []
            }]
        ]
    }
});

I also added some little changes in code (e.g. split up built process to make parts of them work under windows or pass empty object as oprationMenu config if none set).

simialbi avatar May 18 '20 08:05 simialbi

@simialbi thanks for this work, have also integrated and it works nicely. Performance when inserting larger tables is slow however - any ideas how to fix?

delewis13 avatar Jun 23 '20 06:06 delewis13

Could not reproduce it. Which size are you talking about?

simialbi avatar Jun 23 '20 07:06 simialbi

7x7. Could be due to my integration with ReactQuill in that case if you are unable to reproduce. Thanks for the reply, will keep you posted if I find the cause


From: simialbi [email protected] Sent: Tuesday, June 23, 2020 5:11:33 PM To: soccerloway/quill-better-table [email protected] Cc: delewis13 [email protected]; Comment [email protected] Subject: Re: [soccerloway/quill-better-table] Integrate the tool of inserting table into the toolbar module of quill (Fix #34) (#56)

Could not reproduce it. Which size are you talking about?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/soccerloway/quill-better-table/pull/56#issuecomment-647954744, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEZMJXPIS2QTFWKMSJ4DPXDRYBISLANCNFSM4ND3IPOQ.

delewis13 avatar Jun 23 '20 07:06 delewis13

why don't you merge it ?

Daedra22 avatar Jun 18 '22 11:06 Daedra22