openthread_nrf52_arduino icon indicating copy to clipboard operation
openthread_nrf52_arduino copied to clipboard

Published 20 hours ago • verified publisher icon soburi

Add support for Makerdiary nRF52840 MDK dongle

Open Brezensalzer opened this issue 3 years ago • 3 comments

Digital Pins, I2C, SPI, Serial (USB) and OpenThread was successfully tested. Thank You for Your support!

Brezensalzer avatar Jan 28 '22 13:01 Brezensalzer

@Brezensalzer Could you push this patch into the upstream repository ?

This PR is useful for not only my openthread enabled arduino. so It is better to push upstream.

(In actual, I maintain this project with mainly merge upstream updates only. It will keep world peace if you push to upstream project. :-)

I wrote any I noticed to the PR review.

soburi avatar Jan 28 '22 14:01 soburi

Hello soburi, when using CircuitPython the board enumerates with vid 0x239A and pid 0x80DD, so I've used that. I have also fixed the analog pin definition.

This PR is useful for not only my openthread enabled arduino. so It is better to push upstream.

You have a point there. I will make a pull request on the upstream Adafruit repository. Thank You for Your support!

Brezensalzer avatar Jan 29 '22 09:01 Brezensalzer

@Brezensalzer ,

You have a point there. I will make a pull request on the upstream Adafruit repository.

That's good! Since I'm watching the upstream repository, I will quickly apply the changes once it merges into the upstream.

when using CircuitPython the board enumerates with vid 0x239A and pid 0x80DD, so I've used that.

hmm... I think it's better to remove it. (I'm not sure if the CircuitPython package supports a 'use_1200bps_touch' to flash. It is good to consult to upstream project when push.)

soburi avatar Jan 31 '22 23:01 soburi