filmic-blender
filmic-blender copied to clipboard
sobotka
Adobe RGB
It is on the TODO. Sadly they are display referred, but I will support the transform.
It will likely be added in the next wider gamut iteration, but not into this repository. The stanzas shouldn't be too difficult to design for those keen.
You “think”? What is your context? Are you loading AdobeRGB imagery or do you have an AdobeRGB display?
I'm using adobergb display (dell u2713h) and have some textures in adobergb, own made backplates mainly. They are currently converted into srgb ofc.
OCIO v1 doesn’t provide a clean mechanism to clip out of gamut values, so you’ll need to take that into account in your own pipeline. Give me a few...
Do you also plan to add Rec.2020 and DCI-P3? I don't use them but looks like they will be needed at some point.
I'm not too concerned with things that people don't have or aren't using exclusively yet. It requires actual people with actual needs and hardware to test.
Please test https://github.com/sobotka/filmic-blender/tree/with-AdobeRGB
Pure AdobeRGB works, but Filmic Log View Transform doesn't, on both sRGB and Adobe. I've checked master branch and it works ok there, for sRGB ofc. On a daily basis I use config distributed with blender and I see that input color space naming has changed:
- Non-Color is now Non-Color Data
- sRGB is now sRGB OETF This way all maps are now switched into sRGB OETF. This is quite a problem with non-color maps like normals and roughness as it requires manual adjustment of all non-color maps in all current projects. Is it possible to keep previous names, just "sRGB" and "Non-Color"?
Aliases are a part of OCIO v2. I’m not mangling up this config to appease Blender poor design choices. Other folks using other software use it too.
There are specific roles that are set and Blender should honour, but that’s on Blender.
https://github.com/sobotka/filmic-blender/blob/master/config.ocio#L22
What is wrong with the AdobeRGB Filmic Log specifically?
For both sRGB and AdobeRGB Filmic log doesn't work, nothing happens when I switch into. Even greyscale doesn't work.
Ah, my bad, looks like it works fine. Take a look @ line 52, shouldn't be AdobeRGB there? And line 199 in description, same thing.
Good spot. The AdobeRGB wasn’t working obviously, due to being Apple’s Display P3. Give it a test. This is untested as I committed the fixes via the browser.