digger
digger copied to clipboard
sobomax
Please merge my various changes and fixes
Hi Michael, that's nice chunk of work thank you. There are however some issues that I see might need some refining, such as licensing for example or build flags. It would be extremely helpful if you can break this pull request into smaller chunks that would be easier to discuss and merge, i.e. new key redefinition code, command parameters bugfixes etc.
Yes, but I know of NO program/tool that prints debug stuff on stderr per default. Or have you ever seen a MySQL, Exim, vi, or whatever doing so?!? The right way is (IMHO) to provide a "-d" command line option to enable the output of debug stuff. And validation.... oh come on.... show me just a single validation that is done when DEBUG is defined....
Bye,
Michael
Oh.... I have not seen this..... you are right.... Then better add a hint in the README
As you might has noticed, I've "re-enabled" the cross compile on travis again... The time I've removed the Windows build on travis I was too dumb to get what you are doning there ;-) Shame on me...
Hmpf.... Then I have to create a "feature branch" for every feature that I've implemented and create a pull request from this branch, right?!? I'm still learing git... Sometimes it is wonderful, sometimes I really don't get it.... :-(
Well, if nothing else it tests that all printfs() within DIGGER_DEBUG blocks are functional. ;-) CI task is to do boring things that you won't bother to do yourself. And yes, there are ton on tools that have an option to dump debug stuff to the stderr, but yes, having an option to dump it to the file would be quite useful too. In any case I've added a way to run this build or that.
-Max
On Mon, Sep 11, 2017 at 12:58 PM, Michael Knigge [email protected] wrote:
Yes, but I know of NO program/tool that prints debug stuff on stderr per default. Or have you ever seen a MySQL, Exim, vi, or whatever doing so?!? The right way is (IMHO) to provide a "-d" command line option to enable the output of debug stuff. And validation.... oh come on.... show me just a single validation that is done when DEBUG is defined....
I usually create a branch off the targets's repo master, cherry-pick group of related commits from my own master and make pull request off that. Otherwise you are asking the other person to sort through whole bunch of loosely related changes. :(
-Max
On Mon, Sep 11, 2017 at 1:02 PM, Michael Knigge [email protected] wrote:
Hmpf.... Then I have to create a "feature branch" for every feature that I've implemented and create a pull request from this branch, right?!? I'm still learing git... Sometimes it is wonderful, sometimes I really don't get it.... :-(
I'll do my very best to do it better next time... I promise ;-)
I had a flush when I've been coding ;-) I'll resolve the conflicts soon - gimme a little time....
Hope everything is fine now... I've seen that you've worked on the main.c - I'll x-check if my fixes still work. If not I'll open e new pull request - yes, on a separate branch ;)
Is anything still wrong with my Pull-Request? The change you've requested (no F11 for toggling fullscreen) has been done by yourself already....