sobolevn

Results 1343 comments of sobolevn

Sorry, I cannot reproduce. Both `eradicate` and `flake8-eradicate` are fine with both examples.

JFYI: a lot of module-level checks are covered in [`wemake-python-styleguide`](https://github.com/wemake-services/wemake-python-styleguide) that uses `pep8-naming` as a dependency.

I don't agree on this one. Many people use `fixture`s for custom complex asserts. I can even say that this is the best practice. Examples: - https://github.com/wemake-services/wemake-python-styleguide/blob/master/tests/test_visitors/conftest.py#L12-L37 - https://github.com/wemake-services/wemake-python-styleguide/blob/master/tests/test_visitors/conftest.py#L40-L66

Yes, this seems legit! 👍

@5j9 I would say that `constant` is a misleading name. 'Module level variable' is better. And by convention we name these variables as UPPER_CASE.

I use `wemake-python-styleguide` that has this rule: https://wemake-python-stylegui.de/en/latest/pages/usage/violations/naming.html#global-module-level-variables

What about `skipif(True)`?

No, I should not 🙂 Please, take a look at my sample: ```python pytestmark = pytest.mark.xfail _ValueType = TypeVar('_ValueType') _NewValueType = TypeVar('_NewValueType') class _Wrapper( BaseContainer, SupportsKind1['_Wrapper', _ValueType], mappable.Mappable1[_ValueType], ): _inner_value:...

That's why I have added a note about a configuration: ``` It is probably a good idea to make this configurable: tests path style: with __init__.py or without ```

3. When you have duplicate test names