Sobit Neupane
Sobit Neupane
@dukenv0307 Is it present on main as well or is it introduced by this PR? I feel like it is present in main branch as well. In that case, I...
@bondydaa This PR can not be tested on native due to [this issue](https://github.com/Expensify/App/pull/17699#issuecomment-1521697676). Should we hold this PR for the issue to be solved?
@bondydaa Yes. We get [the same warning](https://github.com/Expensify/App/pull/17699#issuecomment-1521697676) in `main` as well. We get the warning when url is in `/r/:reportID/participants` or `/r/:reportID/details` format but not on `/r/:reportID`.
@dukenv0307 As suggested by @bondydaa [here](https://github.com/Expensify/App/pull/17699#issuecomment-1526056827), can we get rid of https://github.com/Expensify/App/blob/6f0888ca261d12c327852f548350b18b618ba65f/src/libs/Navigation/AppNavigator/MainDrawerNavigator.js#L100-L104 part of code (which should automatically solves our issue). This part of code was introduced to redirect user...
@dukenv0307 Yes. It is expected to open `SibeBarScreen` instead of recent report in small screen device if no reportID is supplied in url.
@chenxidev1129 Thanks for [your proposal](https://github.com/Expensify/App/issues/18067#issuecomment-1525341915). Looks like you are a new contributor. Please go through [the contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributingGuides/CONTRIBUTING.md) if you have not already. We expect some concrete proposal. Your proposal...
Overall the [proposal](https://github.com/Expensify/App/issues/18067#issuecomment-1531150268) looks good to me. But I was able to reproduce the issue with the proposed changes as well. @romulo114 Can you please share the code diff. I...
> say onFinishedPicking, which we can trigger when the window regains focus (which should reliably trigger on either cancel or opening a file) @jjcoffee Can you please add the explanation...
@allroundexperts Thanks for your proposal. The use of delays and setTimeout should be the last resort. So, I believe firstly, we should look for other solutions if any. Your alternative...
@Snehal-Techforce Thanks for the proposal. The use of `setTimeout` is highly discouraged. Let's look for the solution that doesn't use delays.