Sobit Neupane

Results 102 comments of Sobit Neupane

Yeah. I totally agree with you that the onKeyDown event listener is causing the issue. But your proposal should also include fix to the issue for which onKeyDown event listener...

@s77rt Your [proposal](https://github.com/Expensify/App/issues/12010#issuecomment-1312059021) does not completely solve the issue. On tabbing, the focus must rotate among download, close and enter the password. Expected -> Download -> Close -> Enter the...

Thank you @hellohublot for your findings. I believe we prefer approach of solving the issue upstream (soultion B of the [proposal](https://github.com/Expensify/App/issues/11854#issuecomment-1301793683)). But https://github.com/react-native-image-picker/react-native-image-picker/pull/2036 has not received much attention from maintainer....

@hellohublot Will you be able to confirm the following? > Can we confirm there are not bad consequences of downgrading to 4.8.4?

So, the issue with downgrading to 4.8.4 is https://github.com/Expensify/App/issues/9424. I don't think it's good idea to use the following as it is yet to be tested and approved. > ```diff...

Based on this [discussion](https://expensify.slack.com/archives/C02NK2DQWUX/p1667944956842919?thread_ts=1667850311.631759&cid=C02NK2DQWUX), this issue can be closed. cc: @techievivek

@marcaaron I don't have access to Crashlytics dashboard >5. Verify that a crash report was generated in the Crashlytics dashboard

PR was deployed to production 11 days ago. Requesting for C+ payment here as I don't have access to the [linked issue](https://github.com/Expensify/Expensify/issues/230440). cc: @marcaaron @dangrous