Shodai Suzuki comments

Results 135 comments of


                                            Shodai Suzuki

trafficstars

feat(query): support custom-fetch-hook

@izumin5210 Could you fix the failing tests?

feat(query): support custom-fetch-hook

Yes, there is a conflict, so I will close it for now. If a new issue arises, I will revisit this.

MSW mocks seem to "not consequently apply" "required:true" to anyOf elements that could be null

Hi @snext-twilde , We are currently rewriting the relevant source code in #1815, so we recommend that you wait for this PR to be merged before checking again.

MSW mocks seem to "not consequently apply" "required:true" to anyOf elements that could be null

@AllieJonsson @melloware It is a make sense to have a property contain null only if `nullable: true` is specified like a below: ```yaml Pet: type: object required: - id -...

MSW mocks seem to "not consequently apply" "required:true" to anyOf elements that could be null

@snext-twilde In other words, there are cases where null is returned even if it is not defined when an error occurs, so you want to consider that case as well,...

MSW mocks seem to "not consequently apply" "required:true" to anyOf elements that could be null

@snext-twilde Thank you for your explanation. So, could you please tell me with actual code what kind of output you expect for what kind of input?

MSW mocks seem to "not consequently apply" "required:true" to anyOf elements that could be null

@snext-twilde Ah, even if `nullable: true`, you don't want to include `null` in the generated mock response pattern, right? Is the reason why you set `nullable: true` in spite of...

MSW mocks seem to "not consequently apply" "required:true" to anyOf elements that could be null

@snext-twilde @AllieJonsson Well, how about making the default mock function individually exportable as shown below? Before: ```ts export const getListPetsResponseLabradoodleMock = ( overrideResponse: Partial = {}, ): Labradoodle => (...

Feature Request: Add operationId to queryKey for better React Query hook identification

I've retraced the steps so far. First, if you want to customize the query key, you can currently do so by using `override.query.querykey`. https://orval.dev/reference/configuration/output#querykey For `mutator`, starting with #1730, the...

feat(fetch): add ability to throw on error

@AllieJonsson Thanks for the improvement. In addition to this case, there is a case where error handling is done in `custom-fetch`. There are many ways to handle error handling, such...