diff-so-fancy
diff-so-fancy copied to clipboard
so-fancy
Draw ruler and box around headers - rebased
This PR is the same as PR #398, I have just rebased it onto the current next so that there are no conflict. Just some re-tabbings were needed.
I'm doing this as the PR still seems to work well, and it would be a shame to lose the amount of work that @ericbn did.
Couple of quick questions while I review this:
- Can you provide a screenshot of what the output before/after this change?
- Does this pass all the current unit tests?
- This is a pretty large change so this feature would need to be behind
git configoption so users can opt-in to it
@scottchiefbaker fwiw there's a comparison screenshot in the original PR: https://github.com/so-fancy/diff-so-fancy/pull/398#issuecomment-782520586
I have to admit I'm not really familiar with the codebase, nor I really know Perl. This is mostly a feature that I have wanted for a long time, and after seeing the older PR stay there for a while I just thought I'd give it a spin, and I didn't really do a lot of work to make it run again -- all credit goes to the original author.
AppVeyor seems to say that the build is failing, so I'm assuming some tests do fail; perhaps looking for full lines where partial lines get outputted with this patch. I think those tests did not exist when the patch was first proposed.
If there's anything I can do with my limited knowledge to help this be put in, I can try, but as I said I'm unfamiliar with both the language and the codebase so I'm limited in what I can offer.
In fact, I can already attest to a minor bug: if a file changed takes more than one line, the line wraps are incorrect.
Current:
With PR: