diff-so-fancy icon indicating copy to clipboard operation
diff-so-fancy copied to clipboard

`my $VERSION = "1.4.2";` in 1.4.3 version bump

Open rlue opened this issue 2 years ago • 2 comments

Namely, a673cb4

rlue avatar Jul 29 '21 13:07 rlue

(To clarify, I mean to say that line 3 of the diff-so-fancy script was not updated in this commit, not that any change in this commit was erroneous.)

rlue avatar Jul 29 '21 13:07 rlue

I (@scottchiefbaker) maintain the Perl code and handle the GitHub releases. Other people work on the npm versions and specific packages versions. Looks like in this case there was a minor discrepancy in the cycle.

@paulirish am I correct in my understanding that the package.json file is an npm thing? Personally I never touch that file, so I just assume it's for something you do?

scottchiefbaker avatar Apr 07 '22 14:04 scottchiefbaker

I think the issue is that the version in package.json was updated if you check out the v1.4.3 tag, but that the $VERSION variable in the script itself is not:

1.4.3: https://github.com/so-fancy/diff-so-fancy/blob/v1.4.3/package.json#L3

1.4.3: https://github.com/so-fancy/diff-so-fancy/blob/v1.4.3/package-lock.json#L3

1.4.2: https://github.com/so-fancy/diff-so-fancy/blob/v1.4.3/diff-so-fancy#L3

1.4.2: https://github.com/so-fancy/diff-so-fancy/blob/v1.4.3/third_party/build_fatpack/diff-so-fancy#L339

barryprice avatar Feb 15 '23 07:02 barryprice

Closing for now, as this is an issue in a past release and we are just about to release a new version which should NOT have this issue.

scottchiefbaker avatar Jun 09 '23 17:06 scottchiefbaker