snyk-eclipse-plugin icon indicating copy to clipboard operation
snyk-eclipse-plugin copied to clipboard

Support disable/enable Code Quality Scan

Open JinwooHwang opened this issue 1 year ago • 9 comments

Description

Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.

Checklist

  • [x] Tests added and all succeed
  • [ ] Linted
  • [ ] CHANGELOG.md updated
  • [ ] README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

JinwooHwang avatar Oct 01 '24 19:10 JinwooHwang

Eclipse Plugin does not support disabling Code Quality Scan which impacts our developers negatively. This feature allows them to disable/enable Code Quality Scan.

JinwooHwang avatar Oct 01 '24 20:10 JinwooHwang

Hi @JinwooHwang-SAS , thanks for the contribution. We are looking at it right now.

bastiandoetsch avatar Oct 02 '24 06:10 bastiandoetsch

Hi @bastiandoetsch , Thank you for reviewing the commit.

There was a failure of build plugin with Maven. I am sorry but could you please help me find someone who can help me with this failure? Thank you.

echo "$encodedString" | base64 -d > $fileName echo "$sha $fileName" > sha256.txt sha256sum -c sha256.txt shell: /usr/bin/bash -e {0} env: JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.12-7/x64 JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.12-7/x64 fileName: ./keystore.jks encodedString: sha: sha256sum: sha256.txt: no properly formatted SHA256 checksum lines found Error: Process completed with exit code 1.

JinwooHwang avatar Oct 02 '24 11:10 JinwooHwang

Yeah, it cannot retrieve & check the signing truststore from the secrets. This is nothing you can fix - I'll have a look a soon.

bastiandoetsch avatar Oct 03 '24 09:10 bastiandoetsch

Thank you so much for your help, @bastiandoetsch .

JinwooHwang avatar Oct 03 '24 09:10 JinwooHwang

I'll try to create the PR under my name (keeping your commit). I suppose it has to do with permissions.

bastiandoetsch avatar Oct 07 '24 06:10 bastiandoetsch

Please rebase against main once this is merged. That should fix the issue.

bastiandoetsch avatar Oct 07 '24 06:10 bastiandoetsch

Thank you @bastiandoetsch. I just rebased it.

JinwooHwang avatar Oct 07 '24 10:10 JinwooHwang

@JinwooHwang-SAS , looks good, I've approved. You'll need to get your commit history gpg signed, though, before I can merge.

bastiandoetsch avatar Oct 07 '24 12:10 bastiandoetsch

Thank you very much @bastiandoetsch . Let me find out how to get the commit history gpg signed, which I've never done before. I am sorry.

JinwooHwang avatar Oct 18 '24 15:10 JinwooHwang

Hi @bastiandoetsch . I've got the commit history gpg signed. Please let me know if I missed anything. Thank you so much for your help.

JinwooHwang avatar Oct 18 '24 17:10 JinwooHwang

Hi @bastiandoetsch . Thank you so much for your help. I appreciate all your support on my first commit.

JinwooHwang avatar Oct 21 '24 13:10 JinwooHwang

Thanks for contributing! It will go into a release tomorrow!

bastiandoetsch avatar Oct 22 '24 14:10 bastiandoetsch

You are very welcome, @bastiandoetsch. Can't wait to see the release!

JinwooHwang avatar Oct 22 '24 15:10 JinwooHwang