gradle-plugin icon indicating copy to clipboard operation
gradle-plugin copied to clipboard

CliDownloader#downloadLatestVersion() uses internal Gradle classes

Open bmuschko opened this issue 4 years ago • 2 comments

While convenient, internal Gradle classes should never be used as they can introduce breaking changes with a new Gradle runtime version and therefore may break the consumer of this plugin. Example: https://github.com/snyk/gradle-plugin/blob/master/src/main/java/io/snyk/gradle/plugin/CliDownloader.java#L66

The same behavior can be observed in SnykBinaryTask.

bmuschko avatar Aug 05 '21 14:08 bmuschko

Great suggestion

bmvermeer avatar Aug 05 '21 20:08 bmvermeer

Seems this should be closed. Neither of the classes in the OP are using anything but public gradle API now.

trevjonez avatar Sep 08 '21 16:09 trevjonez