driftctl
driftctl copied to clipboard
feat: add scaleway provider with scaleway_function_namespace resource support
Q | A |
---|---|
🐛 Bug fix? | no |
🚀 New feature? | yes |
⚠ Deprecations? | no |
❌ BC Break | no |
🔗 Related issues | |
❓ Documentation | yes |
Description
Hello :wave:
First of all, thanks for this great tool! :heart_eyes:
This PR adds support for Scaleway provider. Scaleway is an european cloud provider.
I've followed the documentation to add a new provider, and also added a new resource (for testing purpose): scaleway_function_namespace
(a resource related to the serverless function product to logically group serverless functions). For reference, the description of scaleway_function_namespace
is here, and the Terraform definition is here. I have added unit and acceptance tests to verify everything works properly.
If this PR is satisfying, I'll try to add more resources. It should be probably possible to add more resources automatically from the Go SDK or the Terraform provider.
I also have a few questions since it's my first PR here (I've added GitHub comments on the related code).
Thank you very much :smiley:
Codecov Report
Merging #1648 (1d9632d) into main (50f8f2d) will decrease coverage by
1.59%
. The diff coverage is75.00%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@
## main #1648 +/- ##
==========================================
- Coverage 79.60% 78.02% -1.59%
==========================================
Files 229 224 -5
Lines 7183 7030 -153
==========================================
- Hits 5718 5485 -233
- Misses 1270 1347 +77
- Partials 195 198 +3
Impacted Files | Coverage Δ | |
---|---|---|
pkg/resource/resource_types.go | 76.47% <ø> (ø) |
|
pkg/resource/schemas/repository.go | 63.88% <50.00%> (-0.54%) |
:arrow_down: |
pkg/resource/scaleway/metadatas.go | 100.00% <100.00%> (ø) |
|
...g/resource/scaleway/scaleway_function_namespace.go | 100.00% <100.00%> (ø) |
Hello @wbeuil :wave: have you had the chance to take a look at this? Any feedback would be appreciated, thanks in advance! Also sorry for the ping, but I don't really know who else to tag :sweat_smile: