driftctl icon indicating copy to clipboard operation
driftctl copied to clipboard

Support for new AWS resources `aws_vpc_security_group_ingress_rule` and `aws_vpc_security_group_egress_rule`

Open rirze opened this issue 1 year ago • 0 comments

Description

Hi,

The AWS provider has released newer, consistent resources for managing security group rules: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpc_security_group_ingress_rule https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpc_security_group_egress_rule

These objects are better at being 1:1 to how AWS manages security group rules, with some benefits being:

  • rules being able to hold tags
  • each rule object only associates one source, unlike the old objects that could reference multiple cidr blocks for example
  • imports are now by security group rule ID, unlike the concatenated property string before

I would assume these new objects would simplify the drift detection code for security group rules in driftctl since they are more straightforward to associate with the corresponding AWS resources. It would be greatly helpful if support could be added in driftctl!

rirze avatar Mar 01 '23 15:03 rirze