driftctl icon indicating copy to clipboard operation
driftctl copied to clipboard

Add support for google-beta provider

Open mdietzer-fn opened this issue 2 years ago • 2 comments

Q A
🐛 Bug fix? no
🚀 New feature? yes (sort of)
⚠ Deprecations? no
❌ BC Break no
🔗 Related issues N/A
❓ Documentation yes (the new gcp-beta+tf remote)

Description

This PR adds support for the google-beta provider via the gcp-beta+tf remote.

Reasoning behind supporting google-beta is that several features in GCP require use of the beta provider, and in order to validate IaC infrastructure using that provider, this code is necessary, or driftctl asserts 0% coverage.

As the two providers, beyond their name and version, are basically the same when it comes to driftctl's usage, this is a quite small change

mdietzer-fn avatar Aug 24 '22 16:08 mdietzer-fn

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 24 '22 16:08 CLAassistant

Test failures seem (to me) unrelated to my change, are these expected/flaky?

mdietzer-fn avatar Sep 22 '22 16:09 mdietzer-fn

This would be great. Just curious: how would this work if you're using both regular and beta provider in the same state?

wyardley avatar Dec 28 '22 05:12 wyardley

This would be great. Just curious: how would this work if you're using both regular and beta provider in the same state?

Likely the same way driftctl works with two different providers entirely, like trying to use AWS and GCP providers at the same time (which is to say it does not support that at all)

mdietzer-fn avatar Dec 28 '22 17:12 mdietzer-fn

Likely the same way driftctl works with two different providers entirely, like trying to use AWS and GCP providers at the same time (which is to say it does not support that at all)

Got it. In my experience, it's very common with GCP in terraform to commingle regular and beta provider within the same state, though I imagine using beta only would probably still support the superset of things that are in GA as well most of the time....

wyardley avatar Dec 28 '22 17:12 wyardley

Hi @mdietzer-fn, thank you for reaching out. Please see pinned message: from here

andreeaneata avatar Oct 31 '23 13:10 andreeaneata