actions icon indicating copy to clipboard operation
actions copied to clipboard

Add "arch" input in snyk/actions/setup

Open fabasoad opened this issue 8 months ago • 12 comments

Currently, snyk/actions/setup supports only x86_64 binaries installation but there are also arm64 available for downloading. With arch input it is possible to define architecture (in the same way as os) which will download respective binary.

fabasoad avatar Jul 01 '25 09:07 fabasoad

:white_check_mark: Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
:white_check_mark: Code Security 0 0 0 0 0 issues

:computer: Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

snyk-io[bot] avatar Jul 01 '25 09:07 snyk-io[bot]

Hey @fabasoad - should we extend this test as well for this one? I think this change needs some proof that it's not blowing up anything. 🤔

dotkas avatar Jul 02 '25 08:07 dotkas

@dotkas I've added some tests. Please review.

fabasoad avatar Jul 05 '25 07:07 fabasoad

@dotkas I've added some changes to fix the tests. Please approve workflows to see if my changes fix the issue.

fabasoad avatar Jul 19 '25 04:07 fabasoad

Hi @fabasoad - sorry for the delay. It's been summer holiday season 🌅 I see some tests failing. We've got a pretty big backlog in our team these weeks, so I might be slow to respond. Apologies in advance.

dotkas avatar Aug 04 '25 06:08 dotkas

Hi @dotkas! No worries. I've fixed tests failure. It should work now. Please approve awaiting workflows and let's see if it helps. Thank you.

fabasoad avatar Aug 04 '25 13:08 fabasoad

Hey @fabasoad - thanks for your contributions so far. I agree with this PR, and want to merge it, but I need to stall a bit.

I want to make a "clean slate" in this repo, and get off of master, while at the same time starting doing semantic releases as should be expected. Right now all consumers are pinning to @master or a github SHA.

So I want to get this change in after this is done, to decrease the risk of breaking everybody's pipelines.

dotkas avatar Aug 15 '25 11:08 dotkas

@dotkas Totally makes sense. Looking forward to see semantic releases in this repo 👍

fabasoad avatar Aug 16 '25 14:08 fabasoad

Your PR has not had any activity for 30 days. In 2 days I'll close it. Make some activity to remove this.

github-actions[bot] avatar Sep 16 '25 00:09 github-actions[bot]

@dotkas This is something my team also needs, if it would be possible to see this being merged we would love it.

EhudB avatar Oct 11 '25 07:10 EhudB

Your PR has not had any activity for 30 days. In 2 days I'll close it. Make some activity to remove this.

github-actions[bot] avatar Nov 11 '25 00:11 github-actions[bot]

Your PR has not had any activity for 30 days. In 2 days I'll close it. Make some activity to remove this.

github-actions[bot] avatar Dec 14 '25 00:12 github-actions[bot]